refactor(p2p/simulations): remove unused func setSocketBuffer#2340
refactor(p2p/simulations): remove unused func setSocketBuffer#2340gzliudan wants to merge 1 commit into
Conversation
Remove setSocketBuffer from inproc adapter since it is no longer needed.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Removes the unused setSocketBuffer helper from the in-process simulations adapter (p2p/simulations), reducing dead code in the networking simulation utilities.
Changes:
- Deleted the unreferenced
setSocketBuffer(net.Conn, int, int) errorfunction from the inproc adapter.
Proposed changes
Remove setSocketBuffer from inproc adapter since it is no longer needed.
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which parts of the codebase does this PR touch?
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that