fix(cmake): remove redundant add_definitions(${LLVM_DEFINITIONS})#3021
Draft
FIM43-Redeye wants to merge 3 commits intoXilinx:mainfrom
Draft
fix(cmake): remove redundant add_definitions(${LLVM_DEFINITIONS})#3021FIM43-Redeye wants to merge 3 commits intoXilinx:mainfrom
FIM43-Redeye wants to merge 3 commits intoXilinx:mainfrom
Conversation
HandleLLVMOptions already adds all LLVM compile definitions individually
via add_compile_definitions(). The add_definitions(${LLVM_DEFINITIONS})
calls were redundant and caused garbled -D flags with GCC because
LLVM_DEFINITIONS is a space-separated string, not a CMake list.
Fixes Xilinx#2965.
Generated using Claude Code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add_definitions(${LLVM_DEFINITIONS})from all six CMakeLists.txt files that alsoinclude(HandleLLVMOptions)HandleLLVMOptionsalready adds every flag individually viaadd_compile_definitions(), making these calls purely duplicative-Dflags with GCC becauseLLVM_DEFINITIONSis a space-separated string, not a CMake listFixes #2965.
Test plan
target_model,target_model_rtti, andregister_databaseCppTests build and pass with Clang after removalGenerated using Claude Code.