Skip to content

Fix incorrect casing of Chr() and Ord() in class-pclzip.php #12144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Soean wants to merge 1 commit into from
+3 −3
Closed

Fix incorrect casing of Chr() and Ord() in class-pclzip.php #12144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/wp-admin/includes/class-pclzip.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3988,7 +3988,7 @@ function privExtractFileUsingTempFile(&$p_entry, &$p_options)


// ----- Write gz file format header
$v_binary_data = pack('va1a1Va1a1', 0x8b1f, Chr($p_entry['compression']), Chr(0x00), time(), Chr(0x00), Chr(3));
$v_binary_data = pack('va1a1Va1a1', 0x8b1f, chr($p_entry['compression']), chr(0x00), time(), chr(0x00), chr(3));
@fwrite($v_dest_file, $v_binary_data, 10);

// ----- Read the file by PCLZIP_READ_BLOCK_SIZE octets blocks
Expand Down Expand Up @@ -4616,10 +4616,10 @@ function privReadEndCentralDir(&$p_central_dir)
$v_byte = @fread($this->zip_fd, 1);

// ----- Add the byte
//$v_bytes = ($v_bytes << 8) | Ord($v_byte);
//$v_bytes = ($v_bytes << 8) | ord($v_byte);
// Note we mask the old value down such that once shifted we can never end up with more than a 32bit number
// Otherwise on systems where we have 64bit integers the check below for the magic number will fail.
$v_bytes = ( ($v_bytes & 0xFFFFFF) << 8) | Ord($v_byte);
$v_bytes = ( ($v_bytes & 0xFFFFFF) << 8) | ord($v_byte);

// ----- Compare the bytes
if ($v_bytes == 0x504b0506)
Expand Down
Loading