Update email provider token-message hooks#897
Open
joemaller wants to merge 2 commits into
Open
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
The primary purpose of this PR is to provide the
$tokento the email provider's subject filter. It also brings consistency to the shape of Two Factor's email provider token-message hook arguments, and standardizes the namespaces used by those filters. Includes tests and documentation.Fixes: #898
Why?
Many services now include the login token in their email subject lines like "Your login code is 123456". This improves user-experience and speeds MFA logins.
Previously, the email subject filter did not have access to
$tokenand its arguments did not match the shape of the message filter arguments. Developers wanting to include the token in email subjects had to use clumsy, fragile workarounds.This PR adds (renames) two hooks:
two_factor_email_token_subjecttwo_factor_email_token_messageThis PR deprecates two existing hooks:
two_factor_token_email_subjecttwo_factor_token_email_messageNew hook names provide a clean pathway for changing the signature of
two_factor_token_email_subjectwithout breaking existing functionality. The new filter adds a$tokenargument to match the shape oftwo_factor_token_email_message. This makes it very easy for developers to include$tokenin email subject lines.How?
two_factor_email_token_subjectandtwo_factor_email_token_messagefilters are now symmetrical:$subject|$message, $token, $user_id.Use of AI Tools
AI assistance: Yes
Tool(s): Opencode, browsers
Model(s): grok 4.3, gemini-3.1-pro-preview
Used for: Architectural suggestions, consistency and style-matching with existing code, and code review/QA.
Testing Instructions
Tests covering the changes were added.
Add this line to a theme with Two Factor installed to add the token to the email subject.
Changelog Entry