Skip to content

Detect PUC call in Plugin Updater Check #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ernilambar merged 2 commits into from
Feb 10, 2026
Merged

Detect PUC call in Plugin Updater Check #1168

ernilambar merged 2 commits into from
Feb 10, 2026
+74 −8

Conversation

@ernilambar
Copy link
Member

@ernilambar ernilambar commented Feb 2, 2026 •
edited
Loading

Fixes #1167

  • Add two regexes in look_for_plugin_updaters(): namespace YahnisElsts\PluginUpdateChecker, method PucFactory::buildUpdateChecker.
  • Add PHP Unit test for the changed

@ernilambar ernilambar force-pushed the 1167-updater-puc-usage branch from 3895d4d to 00c4117 Compare February 2, 2026 06:11
@ernilambar ernilambar changed the title Improve updater check Detect PUC call in Plugin Updater Check Feb 2, 2026
@ernilambar ernilambar marked this pull request as ready for review February 2, 2026 06:16
@github-actions
Copy link

github-actions bot commented Feb 2, 2026 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <[email protected]>
Co-authored-by: davidperezgar <[email protected]>
Co-authored-by: frantorres <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@davidperezgar
Copy link
Member

davidperezgar commented Feb 2, 2026

LGTM

@ernilambar ernilambar added this to the 1.9.0 milestone Feb 10, 2026
@ernilambar ernilambar merged commit fa8589d into trunk Feb 10, 2026
26 checks passed
@ernilambar ernilambar deleted the 1167-updater-puc-usage branch February 10, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frantorres frantorres frantorres approved these changes

@davidperezgar davidperezgar davidperezgar approved these changes

@chriscct7 chriscct7 Awaiting requested review from chriscct7 chriscct7 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.9.0

Development

Successfully merging this pull request may close these issues.

Plugin Updater Check does not detect PUC library usage

3 participants

@ernilambar @davidperezgar @frantorres