RadioControl: Add role="radiogroup" to fieldset#76745
Draft
Conversation
mirka
added
[Type] Bug
mirka
force-pushed
the
fix/radio-control-radiogroup-role
branch
from
1281b70 to
6c5578e
Compare
|
Size Change: +4 B (0%) Total Size: 7.66 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6c5578e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23368608671
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add
role="radiogroup"to theRadioControlfieldset element.Why?
RadioControlrenders a<fieldset>that contains radio inputs, but the implicit role of<fieldset>isgroup. The WAI-ARIA Radio Group Pattern specifies that a container of radio inputs should userole="radiogroup", which allows assistive technology to convey that the options are mutually exclusive.How?
Add
role="radiogroup"to the<fieldset>inpackages/components/src/radio-control/index.tsx. Update existing unit tests to query by theradiogrouprole instead ofgroup.Testing Instructions
Check the rendered HTML in Storybook.
Use of AI Tools
Authored with Cursor (Claude).