Open
Conversation
ntsekouras
requested review from
jameskoster,
jasmussen,
oandregal and
t-hamano
ntsekouras
added
Needs Design Feedback
ntsekouras
commented
Mar 20, 2026
| @@ -0,0 +1,12 @@ | |||
| .editor-post-revisions-panel { | |||
| .dataviews-layout__container { | |||
Contributor
Author
There was a problem hiding this comment.
The overflow override is something we should fix in DataViews IMO because it seems the 'circle' is aligned a bit more left than the group label.
We should consider what to do with the activity padding rule too. --cc @oandregal
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ntsekouras
commented
Mar 20, 2026
| ) } | ||
| { !! revisionId && ( | ||
| <> | ||
| <VStack spacing={ 1 }> |
Contributor
Author
There was a problem hiding this comment.
Initially I took a different approach trying to preserve the DataForm and actually adjust the fields to just a few.
Later on I observed that the revision info operate on a separate entity entirely (revision) and it doesn't make much sense to add complexity and also create all those new fields for something that is not going to be a DataForm at all.
The simplest (and best IMO) solution is to reuse the same 'view' components from editor package.
Additionally, this is more flexible to the revisions panels, since they might update with the ongoing work of revisions.
|
Size Change: +43.3 kB (+0.57%) Total Size: 7.7 MB
ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Resolves: #76246
Which is part of the bigger: #76076
This PR affects the
Editor Inspector: Use DataFormexperiment and adds arevisionspanel based on the designs shared here.Notes
Budgefor the revisions count seem to make the panel header a bit taller than the restadded/removed/modifiedwithout providing more details.Testing Instructions
Editor Inspector: Use DataFormexperimentrevisionspanelScreenshots