Skip to content

RTC: Backport race condition fix#76649

Open
chriszarate wants to merge 2 commits intotrunkfrom
feat/wp-11292-backport
Open

RTC: Backport race condition fix#76649
chriszarate wants to merge 2 commits intotrunkfrom
feat/wp-11292-backport

Conversation

@chriszarate
Copy link
Contributor

@chriszarate chriszarate commented Mar 18, 2026

What?

Backport race condition fix from WordPress/wordpress-develop#11292

IMPORTANT: This should only be merged if we do not proceed with the custom table approach.

Why?

A race condition exists when applying compaction updates using the default polling provider.

@chriszarate chriszarate added [Type] Task Issues or PRs that have been broken down into an individual action to take [Feature] Real-time Collaboration Phase 3 of the Gutenberg roadmap around real-time collaboration Backport to WP 7.0 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Mar 18, 2026
@github-actions
Copy link

github-actions bot commented Mar 18, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: chriszarate <czarate@git.wordpress.org>
Co-authored-by: alecgeatches <alecgeatches@git.wordpress.org>
Co-authored-by: ingeniumed <ingeniumed@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Flaky tests detected in f91d8e6.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23265816185
📝 Reported issues:

Copy link
Contributor

@alecgeatches alecgeatches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The meta_id-based logic looks correct, and in my local testing I didn't see any odd behavior during compaction. Any interest in moving the tests from WordPress/wordpress-develop#11292 over here?

@chriszarate
Copy link
Contributor Author

Any interest in moving the tests from WordPress/wordpress-develop#11292 over here?

Looks like we're inconsistent in doing so. It's a good suggestion, but might tackle post-RC1 since there could be conflicts with other work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport to WP 7.0 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta [Feature] Real-time Collaboration Phase 3 of the Gutenberg roadmap around real-time collaboration [Type] Task Issues or PRs that have been broken down into an individual action to take

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants