feat: Port Wire.data functionality from TypeScript #17

google-labs-jules · 2025-12-29T17:02:52Z

This change ports the core functionality of Wire.data from the TypeScript version of the library to the Dart version.

This includes:

Adding generics to WireData for type safety.
Implementing listener execution modes (sequential and parallel).
Adding an onError callback for robust error handling.
Making the unsubscribe method asynchronous to prevent race conditions.

PR created automatically by Jules for task 356584983162170934 started by @VladimirCores

google-labs-jules · 2025-12-29T17:02:53Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

lib/src/layers.dart

lib/src/main.dart

lib/src/layers.dart

lib/src/data.dart

VladimirCores · 2025-12-30T20:05:43Z

lib/src/layers.dart

+        if (!_wireById.containsKey(wireId)) continue;
+        final wire = _wireById[wireId]!;
+        if (isLookingInScope && wire.scope != scope) continue;
+        final result = await wire.transfer(payload).catchError(_processSendError);
+        if (wire.withReplies && --wire.replies == 0) {
+          await _removeWire(wire);
+        }
+        if (result != null) {
+          results.add(result);
        }


@jules extract the logic of "transfer on each wire" into separate private method returning result

VladimirCores · 2025-12-30T20:12:07Z

lib/src/main.dart

+      final isValueFunction = value is WireValueFunction;
+      final nextValue = isValueFunction ? value(prevValue) : value;


@jules keep original version of that code

VladimirCores · 2025-12-31T07:39:05Z

lib/src/layers.dart

+    final result = await wire.transfer(payload).catchError(_processSendError);
+    if (wire.withReplies && --wire.replies == 0) {
+      await _removeWire(wire);
+    }


@jules looks like this code has a problem because during wire.transfer there might be another send of same signal (within async call) thus the transfer will happen again even when wire.replies is already 0. Evaluate this case, write tests to cover the case, and fix the code.

…s file. The linter rules have been updated to better reflect current best practices and remove unnecessary configurations.

This commit addresses all outstanding feedback from the previous code reviews: - The `remove` method in `WireDataContainerLayer` has been reverted to be private (`_remove`). - The original logic in the `data` method of the `Wire` class has been restored. - All previously removed commented-out `print` statements have been restored.

This commit ports the core functionality of `Wire.data` from the TypeScript version of the library to the Dart version to achieve feature parity. - Introduces generics (`WireData<T>`) for type safety. - Adds listener execution modes (`SEQUENTIAL` and `PARALLEL`). - Implements an `onError` callback mechanism for robust error handling. - Implements an asynchronous `unsubscribe` method to handle in-flight data refreshes correctly. - Adds a runtime type check in `Wire.data<T>()` to prevent unsafe casting. - Fixes a race condition where a wire with `replies: 1` could be called multiple times during re-entrant `send` calls. - The test suite has been extended to cover all new functionality and the race condition fix.