Add MySQL <-> SQLite Migration (#353)#354
Open
ssquadteam wants to merge 7 commits intoWiIIiam278:masterfrom
Open
Add MySQL <-> SQLite Migration (#353)#354ssquadteam wants to merge 7 commits intoWiIIiam278:masterfrom
ssquadteam wants to merge 7 commits intoWiIIiam278:masterfrom
Conversation
WiIIiam278
requested changes
Mar 30, 2025
Owner
WiIIiam278
left a comment
WiIIiam278
left a comment
There was a problem hiding this comment.
Incredibly thorough PR. Excellent work, thanks for studying the code closely and sticking with the style and for even going the extra mile to update the docs.
A few notes here, but otherwise this looks good :)
common/src/main/java/net/william278/huskclaims/command/HuskClaimsCommand.java
Outdated
Show resolved
Hide resolved
common/src/main/java/net/william278/huskclaims/hook/DatabaseImporter.java
Outdated
Show resolved
Hide resolved
common/src/main/java/net/william278/huskclaims/hook/DatabaseImporter.java
Show resolved
Hide resolved
…lias to MySQL and more
WiIIiam278
approved these changes
Mar 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.