Conversation
…tions Add incomingCallTimeoutMs and outgoingCallTimeoutMs to CallkeepAndroidOptions so callers can align the no-answer disconnect behaviour with their SIP server. Values are persisted via StorageDelegate.Timeout and read by ConnectionTimeout factory methods at connection creation time. Default remains 35 000 ms when not specified. Fixes WT-1273
…ate tests - incomingCallTimeoutMs/outgoingCallTimeoutMs changed from int? to int in CallkeepAndroidOptions (default 60000 always sent over Pigeon, docs updated to reflect that null is no longer a valid state) - Add StorageDelegateTimeoutTest: default 60s, set/get round-trip, incoming and outgoing stored independently
digiboridev
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
incomingCallTimeoutMsandoutgoingCallTimeoutMstoCallkeepAndroidOptionsso callers can configure how long the app waits before auto-disconnecting an unanswered callStorageDelegate.Timeoutand read byConnectionTimeoutfactory methods at connection creation time — no change needed to call sites beyond passingcontextcallkeep.pigeon.dart,Generated.kt) regenerated viaflutter pub run pigeonMotivation
PortaSIP terminates unanswered calls after 120 s. The previous 35 s hardcoded timeout caused CallKeep to disconnect calls on the Android side well before PortaSIP acted, resulting in unexpected early hang-ups (see WT-1273).
Usage
Test plan
incomingCallTimeoutMs: 120000— verify timeout fires after 120 sFixes WT-1273