Skip to content

Comments

Minor spec changes based on TAG feedback#150

Closed
evanbliu wants to merge 2 commits intoWebAudio:mainfrom
evanbliu:MinorTagChanges
Closed

Minor spec changes based on TAG feedback#150
evanbliu wants to merge 2 commits intoWebAudio:mainfrom
evanbliu:MinorTagChanges

Conversation

@evanbliu
Copy link
Collaborator

@evanbliu evanbliu commented Apr 18, 2025

This CL contains the following changes based on TAG feedback (w3ctag/design-reviews#1038 (comment)):

  1. Remove the 'cloud-only' option for SpeechRecognitionMode.
  2. Add a statement that speech recognition should not be personalized when performing speech recognition on a MediaStreamTrack.
  3. Clarify that user agents MAY show a permission prompt when downloading language packs.

Preview | Diff

@evanbliu evanbliu requested a review from padenot April 18, 2025 21:14
1. Initiate the download of the on-device speech recognition language for <var>lang</var>.
<p class=note>
Note: The user agent can prompt the user for explicit permission to download the on-device speech recognition language pack.
Note: The user agent MAY prompt the user for explicit permission to download the on-device speech recognition language pack.
Copy link
Contributor

@jyasskin jyasskin Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're not supposed to use MAY inside a non-normative paragraph like a note, and in fact you should turn on Complain About: accidental-2119 in the bikeshed metadata to flag when you do it by accident (as suggested in #147). Instead, you'll need to specify the actions the UA must take if the user denies permission, similar to "If the user explicitly or implicitly signals that they do not want to start the download" in https://pr-preview.s3.amazonaws.com/webmachinelearning/writing-assistance-apis/pull/47.html#step-download-user-interface.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had it enabled in another PR but forgot to merge, this is now done (with another lint).

1. Initiate the download of the on-device speech recognition language for <var>lang</var>.
<p class=note>
Note: The user agent can prompt the user for explicit permission to download the on-device speech recognition language pack.
Note: The user agent MAY prompt the user for explicit permission to download the on-device speech recognition language pack.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had it enabled in another PR but forgot to merge, this is now done (with another lint).

@evanbliu evanbliu marked this pull request as draft May 15, 2025 23:35
@evanbliu evanbliu closed this May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants