[NFC] revert msvc exclusion in wasm-type-printing#8706
Closed
Changqing-JING wants to merge 2 commits into
Closed
Conversation
Member
|
From the error on CI, it looks like this fix did not reach it? |
Changqing-JING
force-pushed
the
revert-msvc
branch
from
May 16, 2026 05:15
967b418 to
9090260
Compare
Contributor
Author
|
Yes, you are correct. I just checked GitHub release notes. The currently windows-latest runner are still using visual studio 2022. And the migration will be done next month. So I just leave this PR as draft and we can check it later. |
The bug has been fixed in visual studio 2026 https://developercommunity.visualstudio.com/t/msvc-error-C1001:-Internal-compiler-erro/10992638?scope=follow
Changqing-JING
force-pushed
the
revert-msvc
branch
from
June 24, 2026 00:48
9090260 to
3edfe40
Compare
Contributor
Author
|
This PR is not needed anymore since the target code is refactored |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiler crash bug has been fixed in visual studio 2026
https://developercommunity.visualstudio.com/t/msvc-error-C1001:-Internal-compiler-erro/10992638?scope=follow