autohide-window : add margins to the opposite edge if autohide is disabled#468
Open
AKArien wants to merge 1 commit into
Open
autohide-window : add margins to the opposite edge if autohide is disabled#468AKArien wants to merge 1 commit into
AKArien wants to merge 1 commit into
Conversation
AKArien
force-pushed
the
biface-margins
branch
2 times, most recently
from
9633c68 to
18b1485
Compare
Member
|
It doesn't make sense to me, why you would want to workaround a bugged library version.
|
Collaborator
Author
This is the intention, this behaviour is mainly aimed at the would-be correct behaviour, and happens to be less bad until it is
The current version is « not working » |
…abled The margins being mostly a matter of style, this makes it so that if a margin is applied and autohide is disabled, space is reserved on both sides of the window. However, wayfire 0.10.1 with gtk4-layer-shell 1.3 has a bug where auto exclusive zone doesn’t account for the margin size, which causes shell toplevels to go outside of the reserved space. Until this is fixed, on wayfire, this patch only prevents overlap and doesn’t cause the intended behaviour Wayfire issue : WayfireWM/wayfire#3038
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The margins being mostly a matter of style, i propose that if a margin is applied and autohide is disabled, space is reserved on both sides of the window.
For this, we would normally apply the same margin to the opposite edge of the edge on which the panel is placed.
However, wayfire 0.10.1 with gtk4-layer-shell 1.3 has a bug where auto exclusive zone doesn’t account for the margin size, which causes shell toplevels to go outside of the reserved space. For now, adding a margin on the opposite side prevents this overlap.
Wayfire issue : WayfireWM/wayfire#3038
We can hack around this bug by simply doubling the requested opposite margin. Since the problem occurs with wayfire’s latest stable version and we are looking to a release of wf-shell 0.10.1 any time, we could do this and change it to only request the normal margin once the bug is fixed in wayfire. However, this would look jarring on non-wayfire desktops.
example of what things look like currently :
with this patch applied (on wayfire) :
if we request twice the margin for wayfire, the intended behaviour, and what it looks like on other compositors with this patch :
