locker : make fingerprint updates count as activity#466
Merged
Conversation
2bea198 to
9ab23f4
Compare
Collaborator
|
As there are other signals, this triggers more often than it should. Ideally we need it to be inside the |
Collaborator
Author
|
Fair enough, i figured it would be best on anything, as to at least provide the user some sort of feedback that something is happening. But looking back at it, i think it is best to move it to the |
This causes the locker widgets to pop out when the fingerprint widget is updated, as it happens following user activity (fingerprint verification) or to notify the user of a change in sensor state
9ab23f4 to
7c63347
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This causes the locker widgets to pop out when the fingerprint widget is updated, as it happens following user activity (fingerprint verification) or to notify the user of a change in sensor state