Skip to content

locker : make fingerprint updates count as activity#466

Merged
trigg merged 2 commits into
WayfireWM:masterfrom
AKArien:locker-fprint-activity
Jun 4, 2026
Merged

locker : make fingerprint updates count as activity#466
trigg merged 2 commits into
WayfireWM:masterfrom
AKArien:locker-fprint-activity

Conversation

@AKArien
Copy link
Copy Markdown
Collaborator

@AKArien AKArien commented Jun 1, 2026

This causes the locker widgets to pop out when the fingerprint widget is updated, as it happens following user activity (fingerprint verification) or to notify the user of a change in sensor state

@AKArien AKArien requested a review from trigg June 1, 2026 18:28
@AKArien AKArien force-pushed the locker-fprint-activity branch from 2bea198 to 9ab23f4 Compare June 1, 2026 18:44
@trigg
Copy link
Copy Markdown
Collaborator

trigg commented Jun 2, 2026

As there are other signals, this triggers more often than it should. Ideally we need it to be inside the verify-match and verify-no-match branches, and certainly not outside of the VerifyStatus branch

@AKArien
Copy link
Copy Markdown
Collaborator Author

AKArien commented Jun 2, 2026

Fair enough, i figured it would be best on anything, as to at least provide the user some sort of feedback that something is happening.

But looking back at it, i think it is best to move it to the update method, no ?

This causes the locker widgets to pop out when the fingerprint widget is
updated, as it happens following user activity (fingerprint verification) or to
notify the user of a change in sensor state
@AKArien AKArien force-pushed the locker-fprint-activity branch from 9ab23f4 to 7c63347 Compare June 3, 2026 11:44
@AKArien AKArien changed the title locker : make fingerprint sensor signals count as activity locker : make fingerprint updates count as activity Jun 3, 2026
@trigg trigg merged commit 2bdec17 into WayfireWM:master Jun 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants