Add sound chime when players are matched from lobby#1018
Open
Add sound chime when players are matched from lobby#1018
Conversation
Co-authored-by: JamesPHoughton <4304478+JamesPHoughton@users.noreply.github.com>
Co-authored-by: JamesPHoughton <4304478+JamesPHoughton@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] sounds chime when players matched from lobby
Add sound chime when players are matched from lobby
Aug 25, 2025
|
1 similar comment
|
JamesPHoughton
requested changes
Aug 25, 2025
etherpad/install-docker.sh
Outdated
Collaborator
There was a problem hiding this comment.
I don't want to remove this. Why did it get flagged for deletion? Is it not used elsewhere?
Deliberation
|
||||||||||||||||||||||||||||||||||
| Project |
Deliberation
|
| Branch Review |
copilot/fix-707
|
| Run status |
|
| Run duration | 07m 15s |
| Commit |
|
| Committer | James Houghton |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
15
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
e2e/08_Invalid_configs.js • 1 failed test • CI RUN
| Test | Artifacts | |
|---|---|---|
| Returning Player > throws error when github repo is invalid |
Test Replay
Screenshots
|
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Players who have waited a long time in the lobby may be distracted and not notice when a game begins. This PR adds an audio notification to alert players when they are successfully matched and transition from the lobby to their first game stage.
Implementation
Added a
useEffecthook in theStage.jsxcomponent that:westminster_quarters.mp3chime when a player first enters any stage after being matched from the lobbygameMatchedChimePlayedflag stored on the player object to ensure the chime only plays once per sessionTechnical Details
The implementation leverages the existing audio infrastructure used by the countdown feature, ensuring consistency in user experience. The chime plays automatically when the
Stagecomponent first mounts for a player who has just been assigned to a game, addressing the transition point identified in the issue discussion.The solution is minimal (17 lines of code) and follows the established patterns in the codebase for audio handling and player state management.
Fixes #707.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com/usr/lib/apt/methods/https(dns block)o1.ingest.sentry.ionode /home/REDACTED/work/deliberation-empirica/deliberation-empirica/client/node_modules/.bin/vite build(dns block)node /home/REDACTED/work/deliberation-empirica/deliberation-empirica/client/node_modules/.bin/vite(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.