Skip to content

Fixes a bug where task forces with transports do not return when they have finished unloading. - #397

Open
CCHyper wants to merge 1 commit into
Vinifera-Developers:developfrom
CCHyper:team-trans-return
Open

Fixes a bug where task forces with transports do not return when they have finished unloading.#397
CCHyper wants to merge 1 commit into
Vinifera-Developers:developfrom
CCHyper:team-trans-return

Conversation

@CCHyper

@CCHyper CCHyper commented Jun 22, 2021

Copy link
Copy Markdown
Contributor

Closes #231

This pull request fixes a bug where a task force with TransportsReturnOnUnload=yes would not return to the home (starting, loading) cell when it has finished unloading.

This fix needs to be extensively tested with all the campaign maps mentioned in the issue, and with how the AI reacts with AI scripts that have TransportsReturnOnUnload=yes set.

@CCHyper CCHyper added the vanilla-bug Something isn't working in the original game label Jun 22, 2021
@CCHyper
CCHyper requested a review from a team June 22, 2021 17:23
@github-actions

github-actions Bot commented Jun 22, 2021

Copy link
Copy Markdown

This comment is automaticly generated by Nightly.link and allows non-registered users to get download the artifacts for this pull request.

These links are also updated when the pull request is pushed to.

@CCHyper
CCHyper force-pushed the team-trans-return branch 4 times, most recently from 47b558d to c6d458e Compare June 27, 2021 20:30
@CCHyper
CCHyper force-pushed the develop branch 7 times, most recently from 8af9b41 to a1e27f3 Compare July 4, 2021 21:16
@PTapioK

PTapioK commented Aug 17, 2021

Copy link
Copy Markdown

Affected singleplayer maps by searching TransportsReturnOnUnload=yes string from the maps using PowerShell:

> Get-ChildItem . -Filter *.map -Recurse | Select-String "TransportsReturnOnUnload=yes" -list -SimpleMatch

fsgdi04.map:2741:TransportsReturnOnUnload=yes
fsgdi06.map:2758:TransportsReturnOnUnload=yes
fsgdi07.map:5230:TransportsReturnOnUnload=yes
fsnod02.map:6914:TransportsReturnOnUnload=yes
fsnod06.map:4247:TransportsReturnOnUnload=yes
fsnod07.map:2434:TransportsReturnOnUnload=yes
fsnod09.map:5608:TransportsReturnOnUnload=yes
gdi12a.map:3895:TransportsReturnOnUnload=yes
gdi5b.map:4176:TransportsReturnOnUnload=yes
gdi5c.map:4380:TransportsReturnOnUnload=yes
gdi6b.map:5039:TransportsReturnOnUnload=yes
gdi7a.map:3644:TransportsReturnOnUnload=yes
gdi8a.map:2262:TransportsReturnOnUnload=yes
gdi9d.map:3629:TransportsReturnOnUnload=yes
nod10a.map:5018:TransportsReturnOnUnload=yes
nod12a.map:6111:TransportsReturnOnUnload=yes
nod7a.map:4525:TransportsReturnOnUnload=yes

@CCHyper
CCHyper force-pushed the develop branch 3 times, most recently from ed8e6d1 to 8a6700f Compare August 31, 2021 22:10
@CCHyper
CCHyper force-pushed the develop branch 4 times, most recently from 9dcb5c1 to 5614754 Compare September 4, 2021 21:52
@CCHyper
CCHyper force-pushed the develop branch 2 times, most recently from b000bdc to 3eb9620 Compare September 15, 2021 21:38
@CCHyper
CCHyper force-pushed the team-trans-return branch from 40de690 to 7fd599a Compare October 1, 2021 21:01
@CCHyper
CCHyper force-pushed the develop branch 2 times, most recently from 29e7495 to 530c32e Compare October 15, 2021 21:02
@CCHyper
CCHyper force-pushed the develop branch 15 times, most recently from 3546546 to fe172ec Compare February 24, 2022 01:32
@CCHyper
CCHyper force-pushed the develop branch 2 times, most recently from 8dadef4 to e3d18b8 Compare March 9, 2022 00:19
@CCHyper
CCHyper force-pushed the team-trans-return branch from 2465c71 to 18f16c8 Compare March 25, 2022 00:08
@CCHyper
CCHyper force-pushed the develop branch 11 times, most recently from 75b5508 to 041ea58 Compare March 31, 2022 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vanilla-bug Something isn't working in the original game

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Vanilla Bug] TransportsReturnOnUnload doesn't work

2 participants