Fix incorrectly renaming pattern match variables#555
Merged
jaskarth merged 3 commits intoVineflower:develop/1.12.0from Mar 29, 2026
Merged
Fix incorrectly renaming pattern match variables#555jaskarth merged 3 commits intoVineflower:develop/1.12.0from
jaskarth merged 3 commits intoVineflower:develop/1.12.0from
Conversation
jaskarth
added
Priority: Medium
jaskarth
reviewed
Mar 28, 2026
Member
jaskarth
left a comment
jaskarth
left a comment
There was a problem hiding this comment.
Thanks for this work! The patch itself looks fine, but I would like to see some new tests to exercise the logic that's added for pattern matches, ternaries, and loops.
| iterate = false; | ||
| // https://docs.oracle.com/javase/specs/jls/se25/html/jls-6.html#jls-6.3.1 | ||
| switch (function.getFuncType()) { | ||
| case BOOLEAN_AND -> { |
Member
There was a problem hiding this comment.
In the VF codestyle, case statements are indented by 1.
fix-pattern-matching-renames
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.