Add protocol parameter to with_request_url test helper#2550
Merged
joelhawksley merged 6 commits intomainfrom Feb 11, 2026
Merged
Add protocol parameter to with_request_url test helper#2550joelhawksley merged 6 commits intomainfrom
joelhawksley merged 6 commits intomainfrom
Conversation
Co-authored-by: joelhawksley <[email protected]>
Co-authored-by: joelhawksley <[email protected]>
Co-authored-by: joelhawksley <[email protected]>
Copilot
AI
changed the title
[WIP] Add ability to set protocol for with_request_url
Add protocol parameter to with_request_url test helper
Feb 11, 2026
Member
joelhawksley
left a comment
There was a problem hiding this comment.
Add a changelog entry too.
Member
|
@copilot I left a review, fix the issues. |
Co-authored-by: joelhawksley <[email protected]>
Contributor
Author
Added CHANGELOG entry under the "main" section in
All review issues have been addressed in commit 94e2dc0:
|
|
|
||
| * Add `protocol` parameter to `with_request_url` test helper to enable testing with HTTPS protocol. | ||
|
|
||
| *Joel Hawksley* |
Member
There was a problem hiding this comment.
😂 if only Copilot would be vain enough to credit itself!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing
*_urlroute helpers with HTTPS currently requires manually settingvc_test_controller.request.env['HTTPS'] = 'on'. This adds aprotocol:parameter towith_request_urlfor cleaner protocol specification.Changes
with_request_urlmethod: Addedprotocol:keyword argument as a symbol (defaults tonilfor backward compatibility)request.schemeviaRack::RACK_URL_SCHEMEtest_helper_test.rband URL generation test inrendering_test.rbUsage
Follows existing patterns for
host:andmethod:parameters. The protocol parameter accepts symbols (:httpor:https) for a cleaner API.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.