fix: prevent Prettify() from corrupting __name__ regex matchers (#60)#61
Merged
f41gh7 merged 1 commit intoVictoriaMetrics:masterfrom Feb 12, 2026
Merged
Conversation
…oriaMetrics#60) The mustGetMetricName() function was extracting metric names from __name__ label filters without checking the operator type. This caused queries with regex matchers like {__name__=~"pattern"} to be incorrectly simplified to {"pattern"}, resulting in silent query corruption. Added checks for IsRegexp and IsNegative flags to ensure only exact match operators (=) on __name__ are treated as metric names, while preserving regex matchers (=~, !~) and negative matchers (!=, !=) as label filters. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #61 +/- ##
=======================================
Coverage 89.69% 89.69%
=======================================
Files 11 11
Lines 2969 2969
=======================================
Hits 2663 2663
Misses 209 209
Partials 97 97 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Thanks for contribution! |
Contributor
|
Bugfix was included into v1.110 and v1.122 LTS branches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
mustGetMetricName()function was extracting metric names from name label filters without checking the operator type. This caused queries with regex matchers like{__name__=~"pattern"}to be incorrectly simplified to{"pattern"}, resulting in silent query corruption.Added checks for IsRegexp and IsNegative flags to ensure only exact match operators
(=)on name are treated as metric names, while preserving regex matchers(=~, !~)and negative matchers(!=, !=)as label filters.Fixes #60
Summary by cubic
Prevented Prettify() from corrupting queries by treating metric names only when name uses an exact = match. Regex (=
), negative (!=), and negative regex (!) on name now remain as label filters, avoiding silent query changes., !, and exact matches to verify correct formatting.Written for commit 9e54372. Summary will update on new commits.