Skip to content

[TF2] Fixed Beach Ball going Invisible when shot at #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoeyCheerio wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[TF2] Fixed Beach Ball going Invisible when shot at #1721

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7da29d
[TF2] Fixes Beach Ball going Invisible when shot at
JoeyCheerio Dec 26, 2025
6e5dca2
Update jigglebones.cpp
JoeyCheerio Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/public/jigglebones.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,14 +588,15 @@ void CJiggleBones::BuildJiggleTransformations( int boneIndex, float currenttime,

data->lastBoingPos = goalBasePosition;

float speed = vel.NormalizeInPlace();
if ( speed < 0.00001f )
float speed;
if ( vel.IsZero() )
Comment on lines +591 to +592

@FlaminSarge FlaminSarge Apr 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the whitespace

@matiaslauriti matiaslauriti Apr 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not to be rude at all, just because the author is not a developer, I would recommend to "suggest" changes directly on the comment, so the author only has to "accept" the change and that's it! Github has the suggestion usage on the markdown code and comment formatting section, and it is awesome!

Suggested change
float speed;
if ( vel.IsZero() )
float speed;
if ( vel.IsZero() )

{
vel = Vector( 0, 0, 1.0f );
speed = 0.0f;
}
else
{
speed = vel.NormalizeInPlace();
speed /= deltaT;
}

Expand Down Expand Up @@ -674,7 +675,7 @@ void CJiggleBones::BuildJiggleTransformations( int boneIndex, float currenttime,
boingSide = CrossProduct( data->boingDir, Vector( 0, 0, 1.0f ) );
}
boingSide.NormalizeInPlace();

@FlaminSarge FlaminSarge Apr 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the whitespace/unrelated change

@matiaslauriti matiaslauriti Apr 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Vector boingOtherSide = CrossProduct( data->boingDir, boingSide );

matrix3x4_t xfrmToBoingCoordsMX;
Expand Down