Replace Radioplayer button with an in-page player#356
Draft
ashhhleyyy wants to merge 18 commits intodevelopmentfrom
Draft
Replace Radioplayer button with an in-page player#356ashhhleyyy wants to merge 18 commits intodevelopmentfrom
ashhhleyyy wants to merge 18 commits intodevelopmentfrom
Conversation
Member
Author
|
Things still to do:
Update: removed scrubbing support from this initial version |
Member
Author
|
Just needs some fixup on the mobile CSS (or alternatively, just use radioplayer on mobile) |
Member
Author
Contributor
|
is the send message updates a duplicate of #292? |
55f2e3f to
181d820
Compare
Member
Author
|
rebased onto development to fix merge conflicts |
ColinRoitt
reviewed
Oct 16, 2024
Contributor
|
Made a few changes, @ashhhleyyy would you check you're happy with these then and we can count that as reviewing both ways |
ashhhleyyy
commented
Nov 6, 2024
Member
Author
ashhhleyyy
left a comment
There was a problem hiding this comment.
need to make a couple tweaks then this should probably be good to go
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




The URY Player(tm)