Use XML launchfile instead of Python#382
Merged
urfeex merged 4 commits intoUniversalRobots:rollingfrom Mar 3, 2026
Merged
Conversation
This starts the description but only supports a subset of the parameters atm.
urrsk
requested changes
Feb 26, 2026
Member
urrsk
left a comment
urrsk
left a comment
There was a problem hiding this comment.
The pipeline says: Error: ROR] [launch]: Caught exception in launch (see debug for traceback): launch configuration 'rviz_config_file' does not exist!
Member
|
Do we need to update any documentation in this regard? |
Member
Author
|
I've updated the documentation accordingly. I also scanned the full assembled documentation on docs.universal-robots.com for the term |
urrsk
approved these changes
Mar 2, 2026
mergify bot
pushed a commit
that referenced
this pull request
Mar 3, 2026
* Add view_robot.launch.xml * Include in python launchfile * Update documentation (cherry picked from commit 7754677) # Conflicts: # doc/index.rst # doc/migration_notes.rst # launch/view_ur.launch.py
mergify bot
pushed a commit
that referenced
this pull request
Mar 3, 2026
* Add view_robot.launch.xml * Include in python launchfile * Update documentation (cherry picked from commit 7754677) # Conflicts: # doc/migration_notes.rst
urfeex
pushed a commit
that referenced
this pull request
Mar 4, 2026
urfeex
pushed a commit
that referenced
this pull request
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've had this lying around locally for quite a while now. Since XML launchfiles are mature enough to be used by now, I would like to use them throughout our ecosystem a bit more. It reduces the complexity to read launchfiles significantly.
I kept the python-based launchfiles for backwards compatibility, though, in the long run I would vote for deleting them, maybe for ROS M.