Conversation
| if (pollingState.previousResponse != null && statusChanged) { | ||
| sendPostMessage('connect/memberStatusUpdate', { | ||
| member_guid: pollingState.currentResponse.guid, | ||
| raw_status: pollingState.currentResponse.raw_status, |
There was a problem hiding this comment.
What are these extra properties used for?
There was a problem hiding this comment.
these expose underlying information as soon as they are available so that clients can start doing their requirements before the widget exit.
There was a problem hiding this comment.
I'm going to need to know the specific use case and why it's absolutely necessary. If it is necessary, then we have to add it to our documentation, and we need to write e2e tests for it to make sure it continues to work. I can't ensure the proper documentation is written if I don't understand why it's necessary.
In a couple weeks we are going to release a new version of ucw-app that doesn't use this old widget anymore, because it uses the new connect widget npm package, so this event will disappear. Are we sure it's even worth adding if it's going to disappear in a couple weeks with the new version?
There was a problem hiding this comment.
these expose underlying information as soon as they are available so that clients can start doing their requirements before the widget exits, this is the specific use case, which is absolutely necessary because we have clients who uses this feature in the old version.
the widget is only a bigginning, at the end the client will use the connection information to call aggregator api and get the data.
the client wants to know the exact/original status from the aggregator so that they can properly use the API , and they want the information as soon as possible. once an account is selected from single_account_select, they will know immediately from this event instead of having to wait for the connection to finish, this saves up to a minute
There was a problem hiding this comment.
I'm not sure if this was communicated after the meeting yesterday, but I think the best strategy for this client is to just fork both the frontend widget repo as well as ucw-app. I'm probably going to merge ucw-app 1.0 today with combo jobs, and this repo will no longer be relevant for the new version.
sophtron-jishun
force-pushed
the
jishun/dev
branch
from
d2e56b0 to
032f959
Compare
2 participants
No description provided.