Update unity_pettingzoo_base_env.py#6136
Open
AmineAndam04 wants to merge 2 commits intoUnity-Technologies:developfrom
Open
Update unity_pettingzoo_base_env.py#6136AmineAndam04 wants to merge 2 commits intoUnity-Technologies:developfrom
AmineAndam04 wants to merge 2 commits intoUnity-Technologies:developfrom
Conversation
|
+1, ran into the same problem. This is especially problematic when only using the mlagents-envs package for environment interfacing, but using own training algorithms (e.g., StableBaselines3). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
in the the
_update_action_spacesmethod of the UnityPettingzooBaseEnv class, you force the actions to be of int32 and in the [-1,1] range (see the code below). This constraint doesn't apply to all scenariosIt makes more sense to use the same logic as in
_update_observation_spaces.We can generalize to all scenarios by using:
Types of change(s)
Checklist
Other comments