Added generation of Get[Required]Option to binder based on the nullability of the type.
#26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ability of the type.
* Default is to use `GetRequiredOption` and only use `GetOption` when the type is explicitly annotated as nullable.
* Note: The term 'required' as used in those APIs is in the retrieval of the property value and throws an exception if not specified as an argument.
- Nullable types are by definition possibly null and therefore are not considered "Required"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added generation of
Get[Required]Optionto binder based on the nullability of the type.GetRequiredOptionand only useGetOptionwhen the type is explicitly annotated as nullable.