pin cartopy<0.26 to fix incompatibillity with geoviews - #1783
Conversation
cmdupuis3
left a comment
There was a problem hiding this comment.
There's another unpinned cartopy in pyproject.toml line 50
That was intentional, but not obvious. Added a comment to clarify! Since the issue is just with cartopy & geoviews, and geoviews is only in "viz" extras, I believe there shouldn't be any need to pin cartopy in "geo" extras. |
cmdupuis3
left a comment
There was a problem hiding this comment.
@Sevans711 Got it, that was my only hangup
rajeeja
left a comment
There was a problem hiding this comment.
Looks good. Keeping the temporary Cartopy pin scoped to the viz extra makes sense because the incompatibility is in GeoViews, while the geo extra does not install GeoViews. The rendered-plot regression coverage catches the actual failure, and the corresponding CI/docs/ASV environments are pinned consistently. All checks pass.
Temporary fix for #1780, but leaving that issue open as a reminder to remove the pin once the new geoviews release is available.
Overview
Pinning cartopy<0.26 avoids the plotting issues described in #1780. Those issues need to be solved directly in geoviews, not in uxarray itself. A fix has been merged upstream (see holoviz/geoviews#884) but the release might take a couple weeks or more. This pin keeps uxarray stable in the meantime.
Updated
test_plot_topology_with_explicit_projectionso that it is actually sensitive to this issue and crashes when using cartopy 0.26.0 (and the latest geoviews, 1.15.1).Once the new geoviews release exists, the pins could be updated, and #1773 can merge. The final state of the pins at that point will likely be: cartopy>=0.26, geoviews>1.15.1, and remove the pin on matplotlib.
PR Checklist
General
Testing & Benchmarking
Documentation and Examples
docs/api.rst; internal (private) function names start with an underscore (_)AI Disclosure
AI Usage: just GitHub Copilot's inline code suggestions.