Skip to content

Write down pull request flow for maintainers #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samcunliffe merged 5 commits into from
Feb 11, 2026
Merged

Write down pull request flow for maintainers #94

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
76c39df
Write down pull request flow for maintainers
samcunliffe Feb 11, 2026
06ad79f
Oupsey
samcunliffe Feb 11, 2026
4073420
Sure, a slightly better sentence. Okay @copilot.
samcunliffe Feb 11, 2026
3b32f1d
Commit rights for requesters.
samcunliffe Feb 11, 2026
a27dda9
Merge branch 'main' into sc/maintainer-rules-to-maximise-development-…
samcunliffe Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,21 @@ typos ospo/business-case.md
There are top-level files: `.vale.ini` and `.typos.toml` to configure each.
In particular, false-positives found by [`typos`] can be [excluded with regular expressions](https://github.com/crate-ci/typos/blob/master/docs/reference.md#example-configurations).

----

## Pull request flow

(Information for maintainers)

- Changes are made via [pull requests](https://github.com/UCL/open-source/pulls); at least one person from the open-source team with commit rights will need to be involved.
- If approved with no comments, **the approving reviewer should merge** (to keep things moving).
- If approved with comments, a requester with commit rights is generally trusted to merge once they're addressed.
- The requester can ask for re-review if they think it's needed or if 'Changes requested'.
- Changes to the business case should have the `business case` label applied.
- Changes to the business case or substantial additions and changes to the text (new guides etc.) should seek review from as many members of the open-source team as can give their time.

----

[email us]: mailto:open.source@ucl.ac.uk
[MyServices]: https://myservices.ucl.ac.uk
[open an issue]: https://github.com/UCL/open-source/issues/new
Expand Down
Loading