Skip to content

broken -> failing #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connoraird merged 1 commit into from
Feb 13, 2026
Merged

broken -> failing #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docker/Dockerfile.ep-5
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
FROM ghcr.io/ucl-arc/fortran-unit-testing-exercises:main

COPY --chown=vscode episodes/5-debugging-a-broken-test /home/vscode/5-debugging-a-broken-test
COPY --chown=vscode episodes/5-debugging-a-failing-test /home/vscode/5-debugging-a-failing-test

WORKDIR /home/vscode/5-debugging-a-broken-test/challenge
WORKDIR /home/vscode/5-debugging-a-failing-test/challenge

# Fix intentional bug in code
RUN sed -i -E 's/.*matrix\(row, col\) = temp_matrix\(row, col\)/matrix\(col, row\) = temp_matrix\(row, col\)/g' src/matrix_transforms.f90
Expand Down
0 ...ng-a-broken-test/challenge/CMakeLists.txt → ...g-a-failing-test/challenge/CMakeLists.txt
View file
Open in desktop
File renamed without changes.
0 ...bugging-a-broken-test/challenge/README.md → ...ugging-a-failing-test/challenge/README.md
View file
Open in desktop
File renamed without changes.
0 ...-test/challenge/src/matrix_transforms.f90 → ...-test/challenge/src/matrix_transforms.f90
View file
Open in desktop
File renamed without changes.
0 ...g-a-broken-test/challenge/test/.gitignore → ...-a-failing-test/challenge/test/.gitignore
View file
Open in desktop
File renamed without changes.
0 ...broken-test/challenge/test/CMakeLists.txt → ...ailing-test/challenge/test/CMakeLists.txt
View file
Open in desktop
File renamed without changes.
0 ...ken-test/challenge/test/test_transpose.pf → ...ing-test/challenge/test/test_transpose.pf
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions ...ebugging-a-broken-test/solution/README.md → ...bugging-a-failing-test/solution/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ symmetric matrix and is equal to its own transpose, thus the order of the indice
We can fix the src with the following change

```diff
--- a/episodes/4-debugging-a-broken-test/challenge/src/matrix_transforms.f90
+++ b/episodes/4-debugging-a-broken-test/challenge/src/matrix_transforms.f90
--- a/episodes/4-debugging-a-failing-test/challenge/src/matrix_transforms.f90
+++ b/episodes/4-debugging-a-failing-test/challenge/src/matrix_transforms.f90
@@ -22,7 +22,7 @@ contains

do row = 1, nrow
Expand Down