Skip to content

Add the Remaining CAN Frames - #36

Open
FireBoyAJ24 wants to merge 2 commits into
mainfrom
user/jay/add_rudder_heading_can_framer
Open

Add the Remaining CAN Frames#36
FireBoyAJ24 wants to merge 2 commits into
mainfrom
user/jay/add_rudder_heading_can_framer

Conversation

@FireBoyAJ24

Copy link
Copy Markdown
Contributor

Description

  • I have added the remaining CAN frames that we need for our mock CAN transmitter testing to our software team.
  • The most critical logging is the RUDDER_DATA_FRAME that has a CAN ID of 0x204.

Verification

  • Polaris GUI does not crash
  • Polaris GUI stores the rudder and other key can messages in the logs correctly

@digcheese digcheese left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no concerns about the implementation! Have you done any testing with CAN data yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants