Add PowerKit and Gress integrations; replace redundant utilities/extensions by Copilot · Pull Request #812 · Tyrrrz/YoutubeDownloader

Copilot · 2026-04-18T19:19:34Z

Update PowerKit to 1.1.1
Update Gress to 2.2.0
Delete ResizableSemaphore.cs — now in PowerKit
Delete ThrottleLock.cs — now in PowerKit
Delete DirectoryExtensions.cs — Directory.CreateForFile now in PowerKit
Delete CommandExtensions.cs — ExecuteIfCan now in PowerKit
Delete NotifyPropertyChangedExtensions.cs — now in PowerKit
Delete ProcessExtensions.cs — Process.StartShellExecute now in PowerKit
Delete DisposableCollector.cs — replaced by Disposable.Merge from PowerKit
Delete HttpExtensions.cs — HttpClient.DownloadAsync now in Gress.Integrations.HttpClientExtensions
Delete StreamExtensions.cs — only used internally by the deleted HttpExtensions
Delete Url.cs — Url.TryExtractFileName replaced by Uri.TryGetFileName() from PowerKit
Rename CreateDirectoryForFile → CreateForFile at all call sites
Replace DisposableCollector usage with IDisposable _eventSubscription fields; multi-subscription sites use Disposable.Merge
Update using directives in all affected files (add PowerKit.Extensions / Gress.Integrations, remove stale YoutubeDownloader.Utils.Extensions where no longer needed)

…alents Agent-Logs-Url: https://github.com/Tyrrrz/YoutubeDownloader/sessions/7c7349ae-ffce-4c33-b3b5-0882c1659352 Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Tyrrrz · 2026-04-18T20:07:06Z

I think you might be able to replace DisposableCollector with Disposable.Merge entirely @copilot

Agent-Logs-Url: https://github.com/Tyrrrz/YoutubeDownloader/sessions/55d71ace-dd10-4d1a-a4f8-3176e56c8edd Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Copilot · 2026-04-18T20:12:50Z

I think you might be able to replace DisposableCollector with Disposable.Merge entirely @copilot

Done in 50547b8. DisposableCollector is deleted — all 6 call sites now hold an IDisposable _eventRoot field. Classes with a single subscription assign it directly; those with two (LocalizationManager, DashboardViewModel) use Disposable.Merge(item1, item2).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

av-build-tel-api-v1.avaloniaui.net
- Triggering command: /usr/share/dotnet/dotnet dotnet exec --runtimeconfig /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.2/tools/netstandard2.0/runtimeconfig.json /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.2/tools/netstandard2.0/Avalonia.BuildServices.Collector.dll (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Tyrrrz · 2026-04-18T20:18:48Z

@copilot rename _eventRoot to _eventSubscription

Agent-Logs-Url: https://github.com/Tyrrrz/YoutubeDownloader/sessions/91e78ff5-a9a2-4554-be5a-ed8b08165654 Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Copilot · 2026-04-18T20:20:07Z

@copilot rename _eventRoot to _eventSubscription

Done in 895dab0 — renamed across all 6 files.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

av-build-tel-api-v1.avaloniaui.net
- Triggering command: /usr/share/dotnet/dotnet dotnet exec --runtimeconfig /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.2/tools/netstandard2.0/runtimeconfig.json /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.2/tools/netstandard2.0/Avalonia.BuildServices.Collector.dll (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Tyrrrz · 2026-04-19T12:39:58Z

@copilot update PowerKit to the latest pre-release version and check if you can replace more utilities/extensions now. Also check if any of its provided utilities/extensions can be useful to refactor existing code.

Agent-Logs-Url: https://github.com/Tyrrrz/YoutubeDownloader/sessions/01eca976-d1f2-42f0-863a-12cb1f081be0 Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Tyrrrz · 2026-04-19T14:14:44Z

@copilot please fix build errors

Agent-Logs-Url: https://github.com/Tyrrrz/YoutubeDownloader/sessions/ce2f1fa9-2c5e-41e3-a71f-d7f43273051e Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Copilot · 2026-04-19T14:16:18Z

@copilot please fix build errors

Fixed in 9a3ab92 — the YoutubeDownloader.Core.Downloading using directive was accidentally dropped from DashboardViewModel.cs during the refactor. Build now succeeds.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

av-build-tel-api-v1.avaloniaui.net
- Triggering command: /usr/share/dotnet/dotnet dotnet exec --runtimeconfig /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.2/tools/netstandard2.0/runtimeconfig.json /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.2/tools/netstandard2.0/Avalonia.BuildServices.Collector.dll (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Tyrrrz · 2026-04-20T19:04:59Z

@copilot if you update Gress, you should be able to remove a few more extensions I believe.

Agent-Logs-Url: https://github.com/Tyrrrz/YoutubeDownloader/sessions/75bd08fc-28c1-4014-a433-3e5ebc4bfbc5 Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Copilot · 2026-04-20T19:08:48Z

@copilot if you update Gress, you should be able to remove a few more extensions I believe.

Done in bf454e2. Updated Gress to 2.2.0, which adds Gress.Integrations.HttpClientExtensions.DownloadAsync (matching the exact IProgress<Percentage> signature we used). Deleted HttpExtensions.cs and StreamExtensions.cs — the latter was only ever used internally by HttpExtensions. Updated FFmpeg.cs to use Gress.Integrations instead.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

av-build-tel-api-v1.avaloniaui.net
- Triggering command: /usr/share/dotnet/dotnet dotnet exec --runtimeconfig /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.2/tools/netstandard2.0/runtimeconfig.json /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.2/tools/netstandard2.0/Avalonia.BuildServices.Collector.dll (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Tyrrrz · 2026-04-20T19:17:01Z

@copilot also please update PowerKit. It comes with Uri.TryGetFileName() and maybe some other useful things.

…GetFileName Agent-Logs-Url: https://github.com/Tyrrrz/YoutubeDownloader/sessions/9db7dc72-fc1d-4374-8aa6-4a4922ef5bf4 Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Copilot · 2026-04-20T19:22:04Z

@copilot also please update PowerKit. It comes with Uri.TryGetFileName() and maybe some other useful things.

Done in 64bdf99. Updated PowerKit to 1.1.1. The new Uri.TryGetFileName() extension replaces the hand-rolled Url.TryExtractFileName regex — YoutubeExtensions.cs now calls new Uri(thumbnail.Url).TryGetFileName() and Url.cs is deleted.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

av-build-tel-api-v1.avaloniaui.net
- Triggering command: /usr/share/dotnet/dotnet dotnet exec --runtimeconfig /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.2/tools/netstandard2.0/runtimeconfig.json /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.2/tools/netstandard2.0/Avalonia.BuildServices.Collector.dll (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Copilot

Pull request overview

This PR updates the solution to rely on PowerKit and Gress 2.2.0 for common integrations/utilities, removing several local helper/extension implementations that are now redundant.

Changes:

Add PowerKit package references (UI + Core) and bump Gress to 2.2.0 via central package management.
Replace local utility classes (e.g., DisposableCollector, ResizableSemaphore, ThrottleLock, various extensions) with PowerKit/Gress equivalents.
Update call sites/usings accordingly (e.g., Directory.CreateForFile, Process.StartShellExecute, HttpClient.DownloadAsync).

Reviewed changes

Copilot reviewed 39 out of 39 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
YoutubeDownloader/YoutubeDownloader.csproj	Adds PowerKit dependency to the UI project.
YoutubeDownloader/Views/Components/DashboardView.axaml.cs	Switches `ExecuteIfCan` extension import to PowerKit.
YoutubeDownloader/ViewModels/MainViewModel.cs	Uses PowerKit Process extensions for shell execute.
YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs	Replaces `DisposableCollector` with single `IDisposable` subscription.
YoutubeDownloader/ViewModels/Dialogs/DownloadSingleSetupViewModel.cs	Uses PowerKit `Directory.CreateForFile`.
YoutubeDownloader/ViewModels/Dialogs/DownloadMultipleSetupViewModel.cs	Uses PowerKit `Directory.CreateForFile`.
YoutubeDownloader/ViewModels/Dialogs/AuthSetupViewModel.cs	Replaces `DisposableCollector` with single `IDisposable` subscription.
YoutubeDownloader/ViewModels/Components/DownloadViewModel.cs	Replaces `DisposableCollector` with single `IDisposable` subscription; uses PowerKit Process extensions.
YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs	Replaces `DisposableCollector` with `Disposable.Merge`; migrates `ResizableSemaphore` to PowerKit.
YoutubeDownloader/Utils/ResizableSemaphore.cs	Deleted (now provided by PowerKit).
YoutubeDownloader/Utils/Extensions/ProcessExtensions.cs	Deleted (now provided by PowerKit).
YoutubeDownloader/Utils/Extensions/NotifyPropertyChangedExtensions.cs	Deleted (now provided by PowerKit).
YoutubeDownloader/Utils/Extensions/DisposableExtensions.cs	Deleted (no longer needed after PowerKit migration).
YoutubeDownloader/Utils/Extensions/DirectoryExtensions.cs	Deleted (now provided by PowerKit).
YoutubeDownloader/Utils/Extensions/CommandExtensions.cs	Deleted (now provided by PowerKit).
YoutubeDownloader/Utils/DisposableCollector.cs	Deleted (replaced by `Disposable.Merge` / individual `IDisposable` fields).
YoutubeDownloader/Utils/Disposable.cs	Deleted (replaced by PowerKit `Disposable`).
YoutubeDownloader/Localization/LocalizationManager.cs	Uses `Disposable.Merge` + PowerKit property-watch extensions.
YoutubeDownloader/Framework/ViewModelManager.cs	Uses PowerKit collection extensions (`AddRange`).
YoutubeDownloader/App.axaml.cs	Replaces `DisposableCollector` with single `IDisposable` subscription for theme watching.
YoutubeDownloader.Core/YoutubeDownloader.Core.csproj	Adds PowerKit dependency to the Core project.
YoutubeDownloader.Core/Utils/Url.cs	Deleted (replaced by PowerKit URI helpers).
YoutubeDownloader.Core/Utils/ThrottleLock.cs	Deleted (now provided by PowerKit).
YoutubeDownloader.Core/Utils/Http.cs	Uses PowerKit assembly version helper for User-Agent.
YoutubeDownloader.Core/Utils/Extensions/YoutubeExtensions.cs	Deleted (replaced by new thumbnail extension).
YoutubeDownloader.Core/Utils/Extensions/ThumbnailExtensions.cs	New: derives thumbnail image format using PowerKit URI helpers.
YoutubeDownloader.Core/Utils/Extensions/StringExtensions.cs	Deleted (now provided by PowerKit).
YoutubeDownloader.Core/Utils/Extensions/StreamExtensions.cs	Deleted (was only used by removed HTTP extension).
YoutubeDownloader.Core/Utils/Extensions/PathExtensions.cs	Deleted (now provided by PowerKit).
YoutubeDownloader.Core/Utils/Extensions/HttpExtensions.cs	Deleted (replaced by Gress HttpClient integration).
YoutubeDownloader.Core/Utils/Extensions/GenericExtensions.cs	Deleted (now provided by PowerKit).
YoutubeDownloader.Core/Utils/Extensions/CollectionExtensions.cs	Deleted (now provided by PowerKit).
YoutubeDownloader.Core/Utils/Extensions/AsyncCollectionExtensions.cs	Deleted (now provided by PowerKit).
YoutubeDownloader.Core/Tagging/MusicBrainzClient.cs	Migrates `ThrottleLock` usage to PowerKit type.
YoutubeDownloader.Core/Tagging/MediaTagInjector.cs	Uses new `ThumbnailExtensions.TryGetImageFormat`.
YoutubeDownloader.Core/Downloading/VideoDownloadOption.cs	Switches to PowerKit extensions for collection helpers.
YoutubeDownloader.Core/Downloading/FileNameTemplate.cs	Switches to PowerKit `Path.EscapeFileName`.
YoutubeDownloader.Core/Downloading/FFmpeg.cs	Switches to `Gress.Integrations` HttpClient download extension.
Directory.Packages.props	Adds PowerKit `1.1.1` and bumps Gress to `2.2.0`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

add PowerKit package and replace custom utilities with PowerKit equiv…

eab4bfd

…alents Agent-Logs-Url: https://github.com/Tyrrrz/YoutubeDownloader/sessions/7c7349ae-ffce-4c33-b3b5-0882c1659352 Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Copilot AI assigned Copilot and Tyrrrz Apr 18, 2026

Copilot created this pull request from a session on behalf of Tyrrrz April 18, 2026 19:19 View session

Tyrrrz added the enhancement New feature or request label Apr 18, 2026

Copilot started work on behalf of Tyrrrz April 18, 2026 20:08 View session

replace DisposableCollector with Disposable.Merge

50547b8

Agent-Logs-Url: https://github.com/Tyrrrz/YoutubeDownloader/sessions/55d71ace-dd10-4d1a-a4f8-3176e56c8edd Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Copilot AI requested a review from Tyrrrz April 18, 2026 20:15

Copilot finished work on behalf of Tyrrrz April 18, 2026 20:15

Copilot started work on behalf of Tyrrrz April 18, 2026 20:18 View session

rename _eventRoot to _eventSubscription

895dab0

Agent-Logs-Url: https://github.com/Tyrrrz/YoutubeDownloader/sessions/91e78ff5-a9a2-4554-be5a-ed8b08165654 Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Copilot finished work on behalf of Tyrrrz April 18, 2026 20:20

Copilot started work on behalf of Tyrrrz April 19, 2026 12:40 View session

Copilot started work on behalf of Tyrrrz April 19, 2026 13:15 View session

Copilot AI and others added 2 commits April 19, 2026 14:00

Update PowerKit to 1.1.0-a.1

64feba4

Agent-Logs-Url: https://github.com/Tyrrrz/YoutubeDownloader/sessions/01eca976-d1f2-42f0-863a-12cb1f081be0 Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Replace more utilities with PowerKit 1.1.0-a.1 equivalents

9eaec71

Agent-Logs-Url: https://github.com/Tyrrrz/YoutubeDownloader/sessions/01eca976-d1f2-42f0-863a-12cb1f081be0 Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Copilot finished work on behalf of Tyrrrz April 19, 2026 14:08

Update Http.cs

100e7a4

Copilot started work on behalf of Tyrrrz April 19, 2026 14:14 View session

Fix build errors: restore missing using directives in DashboardViewModel

9a3ab92

Agent-Logs-Url: https://github.com/Tyrrrz/YoutubeDownloader/sessions/ce2f1fa9-2c5e-41e3-a71f-d7f43273051e Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Copilot finished work on behalf of Tyrrrz April 19, 2026 14:16

Copilot started work on behalf of Tyrrrz April 20, 2026 19:05 View session

Update Gress to 2.2.0; delete HttpExtensions and StreamExtensions

bf454e2

Agent-Logs-Url: https://github.com/Tyrrrz/YoutubeDownloader/sessions/75bd08fc-28c1-4014-a433-3e5ebc4bfbc5 Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Copilot AI changed the title ~~Add PowerKit and replace redundant utilities/extensions~~ Add PowerKit and Gress integrations; replace redundant utilities/extensions Apr 20, 2026

Copilot finished work on behalf of Tyrrrz April 20, 2026 19:10

Copilot started work on behalf of Tyrrrz April 20, 2026 19:17 View session

Update PowerKit to 1.1.1; replace Url.TryExtractFileName with Uri.Try…

64bdf99

…GetFileName Agent-Logs-Url: https://github.com/Tyrrrz/YoutubeDownloader/sessions/9db7dc72-fc1d-4374-8aa6-4a4922ef5bf4 Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Copilot finished work on behalf of Tyrrrz April 20, 2026 19:23

Tyrrrz approved these changes Apr 20, 2026

View reviewed changes

asd

bd0f25f

Tyrrrz marked this pull request as ready for review April 20, 2026 19:27

Copilot AI review requested due to automatic review settings April 20, 2026 19:27

Copilot started reviewing on behalf of Tyrrrz April 20, 2026 19:28 View session

Copilot AI reviewed Apr 20, 2026

View reviewed changes

Comment thread YoutubeDownloader.Core/Tagging/MediaTagInjector.cs

Comment thread YoutubeDownloader.Core/Utils/Extensions/ThumbnailExtensions.cs Outdated

Tyrrrz and others added 2 commits April 20, 2026 22:34

Potential fix for pull request finding

95bca2c

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

asd

91facba

Tyrrrz merged commit b202937 into prime Apr 20, 2026
11 checks passed

Tyrrrz deleted the copilot/add-powerkit-package branch April 20, 2026 19:44

Uh oh!

Conversation

Copilot AI commented Apr 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Tyrrrz commented Apr 18, 2026

Uh oh!

Copilot AI commented Apr 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Tyrrrz commented Apr 18, 2026

Uh oh!

Copilot AI commented Apr 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Tyrrrz commented Apr 19, 2026

Uh oh!

Tyrrrz commented Apr 19, 2026

Uh oh!

Copilot AI commented Apr 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Tyrrrz commented Apr 20, 2026

Uh oh!

Copilot AI commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Tyrrrz commented Apr 20, 2026

Uh oh!

Copilot AI commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Apr 18, 2026 •

edited

Loading

Copilot AI commented Apr 18, 2026 •

edited

Loading

Copilot AI commented Apr 18, 2026 •

edited

Loading

Copilot AI commented Apr 19, 2026 •

edited

Loading

Copilot AI commented Apr 20, 2026 •

edited

Loading

Copilot AI commented Apr 20, 2026 •

edited

Loading