Skip to content

Added a bulk insert method using transaction #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shusshu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added a bulk insert method using transaction #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 33 additions & 2 deletions ProviGen/src/com/tjeannin/provigen/ProviGenProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import android.content.ContentValues;
import android.content.UriMatcher;
import android.database.Cursor;
import android.database.SQLException;
import android.database.sqlite.SQLiteDatabase;
import android.net.Uri;
import android.text.TextUtils;
Expand Down Expand Up @@ -244,10 +245,10 @@ public Cursor query(Uri uri, String[] projection, String selection, String[] sel
case ITEM_ID:
String itemId = String.valueOf(ContentUris.parseId(uri));
if (TextUtils.isEmpty(selection)) {
cursor = database.query(contractHolder.getTable(), projection, contractHolder.getIdField() + " = ? ", new String[] { itemId }, "", "", sortOrder);
cursor = database.query(contractHolder.getTable(), projection, contractHolder.getIdField() + " = ? ", new String[]{itemId}, "", "", sortOrder);
} else {
cursor = database.query(contractHolder.getTable(), projection, selection + " AND " + contractHolder.getIdField() + " = ? ",
appendToStringArray(selectionArgs, itemId), "", "", sortOrder);
appendToStringArray(selectionArgs, itemId), "", "", sortOrder);
}
break;
default:
Expand Down Expand Up @@ -306,4 +307,34 @@ private static String[] appendToStringArray(String[] array, String element) {
}
}

/**
* Efficient bulk insert using sql transaction
* @param uri
* @param values
* @return the number of rows inserted
*/
public int bulkInsert(Uri uri, ContentValues[] values){
int numInserted = 0;

ContractHolder contractHolder = contracts.findMatching(uri);
Copy link
Copy Markdown
Contributor Author

@Shusshu Shusshu Apr 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Provigen 2.0.0.
This line and the next one can be replaced by
String table = uri.getPathSegments().get(0);

String table = contractHolder.getTable();

SQLiteDatabase sqlDB = openHelper.getWritableDatabase();
sqlDB.beginTransaction();
try {
for (ContentValues cv : values) {
long newID = sqlDB.insertOrThrow(table, null, cv);
if (newID <= 0) {
throw new SQLException("Failed to insert row into " + uri);
}
}
sqlDB.setTransactionSuccessful();
getContext().getContentResolver().notifyChange(uri, null);
numInserted = values.length;
} finally {
sqlDB.endTransaction();
}
return numInserted;
}

}