#1739 #2177 OpenIddict authentication: role section, override scope and role key#1431
#1739 #2177 OpenIddict authentication: role section, override scope and role key#1431Eits-Ian wants to merge 12 commits intoThreeMammals:developfrom
Conversation
raman-m
added
feature
|
@Eits-Ian I see that develop branch in your fork is old. |
raman-m
left a comment
raman-m
left a comment
There was a problem hiding this comment.
4 failed tests!
Could you review & fix them please?
|
Sorry I did not get a chance to look at this till today, should be fixed, have added you as a collaborator, I hadn't looked at this for a couple of years. Need to add process policies, I am really busy at the moment so will not be able to get to this for a while. |
|
The error is at ClaimsToDownstreamPathTests it is not authenticating, I need to take a look at what is happening but it will need to be later |
|
The branch has been rebased onto release/24.0 which has top commit 59b63ea !
|
|
@Eits-Ian Dear author, Will this PR close, is PR related to the following issues?
Please answer ASAP❗ P.S.
What is OpenIddict? It should likely not be part of the PR title; instead, the title should include Ocelot's artifact name or, if necessary, the ASP.NET one. |
raman-m
added
waiting
|
Raman,
I need to go back and look at the code to see what I did but from memory, you could specify the roles/scopes but not use an authorization policy and it worked with openiddict.
I haven't got much time to do much with this at the moment, I will need to get back into it as I must update the api, that use this, but that will not be for a few months.
Best,
Ian.
|
It should be a matter of weeks, not months! |
|
Raman,
With all due respect I have a 3-year clinic project just about to open which I am a part owner of the clinic, and this is my priority, I'm not coding all day long.
Best,
Ian.
|
|
@Eits-Ian |
|
Raman,
As I said I do need to do it, but I will not be able to get to it for a few months, I currently end up losing days weeks to the clinic, then I get back to some coding but that is only a few hours at a time. In a few months the clinic will be open, and I will get back to this, I wish I had more time now, but I work 7 day weeks and all hours so there is just no more to give.
Best,
Ian.
|
|
🆗 Got it! You are super busy… In this case, let me decide what to do with this PR… |
raman-m
force-pushed
the
develop
branch
8 times, most recently
from
c216cdf to
b458f0f
Compare
raman-m
force-pushed
the
develop
branch
20 times, most recently
from
f2d07ee to
d753c93
Compare
2 participants
Fixes #2177
AllowedScopesfeature is not functioning as anticipated during authentication with the OpenIddict server #2177Proposed Changes
"ScopeKey": "oi_scp"to enable OpenIddictSuccessor
Closes #1739