Hard deprecate add_dockerfile() and non-renv variants - #1246
Merged
Conversation
Batch integration: temp-dev → master (golem 0.6.0)
Replace the soft-deprecation warnings in `add_dockerfile()`, `add_dockerfile_shinyproxy()` and `add_dockerfile_heroku()` with `.Defunct()` calls so the legacy non-renv Dockerfile helpers now error and point users at the `add_dockerfile_with_renv_*()` replacements. Drops the now-unreachable internal implementations and the `talk_once()` / `alert_build()` helpers. Closes #1244. ## Hard deprecated - `add_dockerfile()`, `add_dockerfile_shinyproxy()`, and `add_dockerfile_heroku()` are now hard deprecated and will error when called; use the corresponding `add_dockerfile_with_renv_*()` functions instead (#1244). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Removes the `output` and `build_golem_from_source` @PARAM tags from the shared `dockerfiles` Rd page — they were leftovers from the legacy `add_dockerfile()` signature and no longer match any function exposed on the page, which R CMD check flagged as a documented-but-not-in-usage warning. Also trims the `update_tar_gz` description that referenced `build_golem_from_source`. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1244.
Replaces the soft-deprecation warnings in
add_dockerfile(),add_dockerfile_shinyproxy()andadd_dockerfile_heroku()with.Defunct()calls, so the legacy non-renvDockerfile helpers now errorand point users at the
add_dockerfile_with_renv_*()replacements. Dropsthe now-unreachable internal implementations and the
talk_once()/alert_build()helpers.NEWS.md
Hard deprecated
add_dockerfile(),add_dockerfile_shinyproxy(), andadd_dockerfile_heroku()are now hard deprecated and will error whencalled; use the corresponding
add_dockerfile_with_renv_*()functionsinstead (Hard deprecated add_dockerfile #1244).
Test plan
devtools::test()— 602 PASS / 0 FAILdevtools::document()regeneratesman/dockerfiles.Rdcleanlyexpect_error()covers the three defunct entrypointsdevtools::check()clean on CI🤖 Generated with Claude Code