Merged
Conversation
Baseline data is only used by event-based windowing. Previously, the baseline folder was generated unconditionally for all window types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Baseline Folder Fix
Only generate baseline folder when event-based windowing is enabled
Summary
eventEnabledcheck inWindows.generateWindows()baseline/folder was created for every window type (tumbling, expanding, hopping), even though onlyevent-based windowing uses baseline data
Change
File:
src/main/java/com/github/thed2lab/analysis/Windows.javaThe
generateBaselineFiles()call was unconditional. It is now scoped to theif (settings.eventEnabled)block, sothe
baseline/folder and its contents (baseline.csv,baseline_DGMs.csv) are only generated when event-basedwindowing is selected.
Testing