bazel/tcl: migrate from rules_hdl tcl to bazel BCR tcl version#290
bazel/tcl: migrate from rules_hdl tcl to bazel BCR tcl version#290fredowski wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
The sta submodule needs to be modified to use the bcr tcl version. I made a PR for the change in the OpenSTA repository here: The-OpenROAD-Project/OpenSTA#290 Signed-off-by: Friedrich Beckmann <friedrich.beckmann@tha.de>
|
@QuantamHD @maliberty Can you have a look and merge ? |
The sta submodule needs to be modified to use the bcr tcl version. I made a PR for the change in the OpenSTA repository here: The-OpenROAD-Project/OpenSTA#290 Signed-off-by: Friedrich Beckmann <friedrich.beckmann@tha.de>
The tcl version in the bazel central registry supports MacOS and it can be used via MODULES.bazel instead of WORKSPACE. Signed-off-by: Friedrich Beckmann <friedrich.beckmann@tha.de>
The sta submodule needs to be modified to use the bcr tcl version. I made a PR for the change in the OpenSTA repository here: The-OpenROAD-Project/OpenSTA#290 Signed-off-by: Friedrich Beckmann <friedrich.beckmann@tha.de>
The sta submodule needs to be modified to use the bcr tcl version. I made a PR for the change in the OpenSTA repository here: The-OpenROAD-Project/OpenSTA#290 Signed-off-by: Friedrich Beckmann <friedrich.beckmann@tha.de>
|
@QuantamHD @maliberty can you approve and merge ? |
|
mmh, looks like |
|
Ah, looks like this accidentally worked as the other PR updated this fork in a separate commit. So that commit is disconnected from anything. So this PR still needs to be merged, to then have a clean submodule update in OpenROAD. |
|
Yes, this is github magic. The commit is in my forked OpenSTA. For me it looks like this:
The bazel-tcl branch is the one from the tcl pr. |
|
I pinged @maliberty |
|
I am holding PRs to this repo while we sort out if we will need a CLA or the like (as in the parallax repo). Hopefully it will be quick but I want ensure contributions are correctly handled. |
4 participants
The tcl version in the bazel central registry supports MacOS and it can be used via MODULES.bazel instead of WORKSPACE.