Skip to content

ram: Coverity fixes#10128

Merged
maliberty merged 3 commits intoThe-OpenROAD-Project:masterfrom
braydenlouie:pdk-support
Apr 14, 2026
Merged

ram: Coverity fixes#10128
maliberty merged 3 commits intoThe-OpenROAD-Project:masterfrom
braydenlouie:pdk-support

Conversation

@braydenlouie
Copy link
Copy Markdown
Contributor

@braydenlouie braydenlouie commented Apr 14, 2026

Summary

Fixing performance inefficiency with tri_enable_name

Type of Change

  • Bug fix

Impact

Moves tri_enable_name string to map as opposed to creating copy

Verification

  • I have verified that the local build succeeds (./etc/Build.sh).
  • I have run the relevant tests and they pass.
  • My code follows the repository's formatting guidelines.
  • I have signed my commits (DCO).

Signed-off-by: braydenlouie <braydenl9988@gmail.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request optimizes the buildPortMap function in src/ram/src/ram.cpp by using std::move when assigning tri_enable_name to the pin_map, which avoids an unnecessary string copy. I have no feedback to provide.

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@braydenlouie braydenlouie marked this pull request as ready for review April 14, 2026 02:11
@braydenlouie
Copy link
Copy Markdown
Contributor Author

@rovinski @maliberty PR is ready for review

@rovinski rovinski requested a review from maliberty April 14, 2026 02:24
@maliberty maliberty merged commit c1bfb6e into The-OpenROAD-Project:master Apr 14, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants