Skip to content

Fixed recursion error in HeaderClock by restricting refresh to the ac… #6373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexyzhao24 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed recursion error in HeaderClock by restricting refresh to the ac… #6373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/textual/widgets/_header.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,11 @@ class HeaderClock(HeaderClockSpace):
time_format: Reactive[str] = Reactive("%X")

def _on_mount(self, _: Mount) -> None:
self.set_interval(1, callback=self.refresh, name="update header clock")
def check_and_refresh() -> None:
if self.screen is self.app.screen:
print("active clock ticks") #temp, REMOVE LATER
self.refresh()
self.set_interval(1,callback=check_and_refresh,name="update header clock")

def render(self) -> RenderResult:
"""Render the header clock.
Expand Down