Setup framework for error provider services#4149
Merged
soyarsauce merged 5 commits intomobxfrom Mar 26, 2020
Merged
Conversation
Contributor
soyarsauce
approved these changes
Mar 26, 2020
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
First part of TerriaJS/TerriaMap#430
This PR sets up some basic pieces for configuring error handling services like rollbar, or sentry etc. A user would pass down a parameter via
config.jsonincluding the API key for the respective service.An app will also need some configuration in TerriaMap index.js to specify which ErrorProvider they want to use. This should prevent things like the rollbar library from being bundled in the application if it's not required.
Checklist