Skip to content

Conversation

@wwwcg
Copy link
Collaborator

@wwwcg wwwcg commented Feb 1, 2026

No description provided.

@wwwcg wwwcg requested review from elixxli and iPel as code owners February 1, 2026 04:59
@wwwcg wwwcg requested review from Copilot and removed request for elixxli and iPel February 1, 2026 05:00
@wwwcg wwwcg requested review from elixxli and zealotchen0 February 1, 2026 05:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Resolves a Gradle build issue by adjusting plugin resolution repositories in settings.gradle.kts.

Changes:

  • Simplifies a custom Maven repo declaration to Kotlin DSL shorthand.
  • Adds an additional Tencent Maven mirror to the pluginManagement.repositories list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 6 to 7
maven("https://mirrors.tencent.com/repository/maven/kuikly-open")
maven("https://mirrors.tencent.com/nexus/repository/maven-tencent/")
Copy link

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding additional Maven repositories in pluginManagement changes where Gradle plugins can be resolved from and increases supply-chain risk (a compromised mirror could serve unexpected plugin artifacts). Consider scoping these repositories with content filters (e.g., restrict to the required plugin groups) or using exclusiveContent/dependency verification so only the intended artifacts can be fetched from these mirrors.

Suggested change
maven("https://mirrors.tencent.com/repository/maven/kuikly-open")
maven("https://mirrors.tencent.com/nexus/repository/maven-tencent/")
maven("https://mirrors.tencent.com/repository/maven/kuikly-open") {
content {
includeGroupByRegex("com\\.kuikly(\\..*)?")
}
}
maven("https://mirrors.tencent.com/nexus/repository/maven-tencent/") {
content {
includeGroupByRegex("com\\.tencent(\\..*)?")
}
}

Copilot uses AI. Check for mistakes.
@tencent-adm
Copy link

tencent-adm commented Feb 1, 2026

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants