Add ability to know if a comment is edited and implement it for YouTube#1513
Conversation
|
Thank you. Please fix the checkstyle errors (https://github.com/TeamNewPipe/NewPipeExtractor/actions/runs/27422345289/job/81074807973?pr=1513#step:6:65) and add corresponding tests to |
|
While running the test suite, I noticed that |
TobiGr
added
enhancement
|
TobiGr
left a comment
TobiGr
left a comment
There was a problem hiding this comment.
Thank you. The failing tests are unrelated. i have squashed your commits and added a formatting fix.
AudricV
left a comment
AudricV
left a comment
There was a problem hiding this comment.
Just some nitpicking to be done at some point, we need to support this feature on other services too.
| } | ||
| } | ||
|
|
||
| assertTrue(hasEditedComment, "No comments is edited on this video. "+"Ensure test video has edited comment near the top."); |
There was a problem hiding this comment.
| assertTrue(hasEditedComment, "No comments is edited on this video. "+"Ensure test video has edited comment near the top."); | |
| assertTrue(hasEditedComment, "No comments is edited on this video. Ensure test video has edited comment near the top."); |
| } catch (final Exception e) { | ||
| addError(e); | ||
| } | ||
|
|
AudricV
changed the title
isEdited state extraction to CommentsInfoItem
AudricV
changed the title
|
@AudricV Thanks for catching that. Since this is already merged, I will open a minor cleanup PR shortly to address these formatting nits. |
| } | ||
| return false; | ||
| } catch (final Exception e) { | ||
| return false; |
There was a problem hiding this comment.
the issue is here: a ParsingException should be thrown
This comment has been minimized.
This comment has been minimized.
4 participants
Description
This PR adds the ability to extract the edited status of YouTube comments to support UI indicators in the main app.
isEdited()boolean toCommentsInfoItem.Checklist