Add more uses of streamAsJsonObjects#1489
Open
Isira-Seneviratne wants to merge 12 commits into
Open
Conversation
ShareASmile
added
the
code quality
Isira-Seneviratne
force-pushed
the
streamAsJsonObjects
branch
from
f747d38 to
715cd77
Compare
absurdlylongusername
requested changes
May 31, 2026
absurdlylongusername
left a comment
absurdlylongusername
left a comment
Member
There was a problem hiding this comment.
Seems mostly okay.
To my understanding, records should work on all versions we support so Java 17 toolchain is fine for now.
Address my comment on YoutubeStreamInfoItemExtractor and then can be merged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up PR to #1485
Breaking
Increases the target and source compatibility java version from 11 to 17.