[YouTube] Refactor some extraction code using Optional#1384
Open
Isira-Seneviratne wants to merge 23 commits into
Open
[YouTube] Refactor some extraction code using Optional#1384Isira-Seneviratne wants to merge 23 commits into
Isira-Seneviratne wants to merge 23 commits into
Conversation
… helper method for extracting music URL
Isira-Seneviratne
force-pushed
the
Refactor-Optional
branch
from
29c7488 to
40181a9
Compare
Isira-Seneviratne
force-pushed
the
Refactor-Optional
branch
from
40181a9 to
30ba0c2
Compare
Isira-Seneviratne
force-pushed
the
Refactor-Optional
branch
from
6b6a7cc to
9dab638
Compare
# Conflicts: # extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeParsingHelper.java # extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java
Isira-Seneviratne
force-pushed
the
Refactor-Optional
branch
from
e3317ac to
a2edb66
Compare
ShareASmile
added
the
code quality
# Conflicts: # extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeMetaInfoHelper.java # extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeParsingHelper.java # extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java # extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamInfoItemExtractor.java
Isira-Seneviratne
force-pushed
the
Refactor-Optional
branch
from
29d6112 to
2597e57
Compare
# Conflicts: # extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeChannelHelper.java # extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java # extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamInfoItemExtractor.java
Isira-Seneviratne
force-pushed
the
Refactor-Optional
branch
from
0922a16 to
36038f4
Compare
Isira-Seneviratne
force-pushed
the
Refactor-Optional
branch
from
e8e750d to
9888fd2
Compare
|
Contributor
|
I am not sure if this is going to be needed anymore. The long-term plan is to port the extractor to kotlin. |
Member
Author
When doing the migration, it could be useful as a guide, e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor some of the helper methods in YoutubeParsingHelper to return
Optional, which allows the number of lines of code to be significantly reduced.