fix(virtual-core): invalidate measurements when gap option changes#1223
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughFixes stale virtualizer measurements when ChangesGap Invalidation Fix
Estimated code review effort: 2 (Simple) | ~12 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 1b32928
☁️ Nx Cloud last updated this comment at |
🎯 Changes
resolves #1222
gapwas missing from thegetMeasurementOptionsmemo dependencies, so a gap-only option change never invalidated cached measurements.The list kept the layout computed with the old
gapuntil something else (count change, item resize, remount) recomputed it.Changes
options.gapto the measurement memo key and thread it through togetMeasurements, replacing the directthis.options.gapreads✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit