Skip to content

Fix missing units field and add convenience getter#160

Merged
BrianMichell merged 2 commits intomainfrom
MetadataGetter
May 27, 2025
Merged

Fix missing units field and add convenience getter#160
BrianMichell merged 2 commits intomainfrom
MetadataGetter

Conversation

@BrianMichell
Copy link
Collaborator

Initial implementation of stats.h did not include unitsV1 field, causing this data to be lost in memory. This bug did not impact on-disk data.

@BrianMichell BrianMichell added bug Something isn't working Improvement Something could be better labels Mar 24, 2025
Copy link
Collaborator

@markspec markspec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrianMichell BrianMichell merged commit c72422b into main May 27, 2025
6 checks passed
@BrianMichell BrianMichell deleted the MetadataGetter branch May 27, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Improvement Something could be better

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants