add build for chan_quectel - #343
Conversation
|
Thanks for the PR @litinoveweedle. How long have you been running this version? And does this module needs to manually be enabled? I'm worried about the long-term stability of this module. |
| # install headers | ||
| make install-headers |
There was a problem hiding this comment.
| # install headers | |
| make install-headers | |
| # install headers for building chan-quectel | |
| make install-headers |
| WORKDIR /usr/src/asterisk-chan-quectel | ||
| # https://github.com/RoEdAl/asterisk-chan-quectel/commits/master | ||
| ARG CHAN_QUECTEL_VERSION="5552c365bfb319eed7cbbf6300a67028ab70db9e" | ||
| RUN curl -fsSL "https://github.com/RoEdAl/asterisk-chan-quectel/archive/${CHAN_QUECTEL_VERSION}.tar.gz" | \ |
There was a problem hiding this comment.
The https://github.com/RoEdAl/asterisk-chan-quectel is archived.
Have you seen https://github.com/IchthysMaranatha/asterisk-chan-quectel? It has been updated more recently, but maybe it lacks the features you need.
If https://github.com/RoEdAl/asterisk-chan-quectel is the best module even though archived, I think we can keep it at least while it doesn't break anything.
felipecrs
left a comment
felipecrs
left a comment
There was a problem hiding this comment.
@litinoveweedle please also update asterisk/rootfs/etc/asterisk/modules.conf to avoid loading this module by default.
|
@litinoveweedle any plans to finish this PR? |
|
Hello I am currently travelling without access to PC. I can review this but earliest in 3weeks. |
1 similar comment
|
Hello I am currently travelling without access to PC. I can review this but earliest in 3weeks. |
|
@litinoveweedle no problem and no rush at all. Just let us know in case you have no plans to finish the PR, though. |
3 participants
No description provided.