Migrate FeedbackDb#13483
Merged
mingyuancode merged 96 commits intoTEAMMATES:V9-clean-slate-sqlfrom Feb 4, 2026
Merged
Conversation
AaronToh
force-pushed
the
V9-clean-slate-sql
branch
4 times, most recently
from
3c17365 to
6263c5e
Compare
AaronToh
force-pushed
the
V9-clean-slate-sql
branch
from
6263c5e to
cbba84d
Compare
mingyuancode
reviewed
Feb 4, 2026
| setStartTime(session, -1); | ||
| setEndTime(session, 3); | ||
|
|
||
| questionNumber = 222; |
Contributor
There was a problem hiding this comment.
Any reason why we are changing the behaviours of the test?
|
|
||
| loginAsInstructor(instructor1OfCourse1.getAccount().getGoogleId()); | ||
|
|
||
| verifyEntityNotFoundAcl(Const.ParamsNames.FEEDBACK_QUESTION_ID, "random"); |
|
|
||
| String[] params = new String[] { | ||
| Const.ParamsNames.FEEDBACK_QUESTION_ID, "non-existent question id", | ||
| Const.ParamsNames.FEEDBACK_QUESTION_ID, "00000000-0000-0000-0000-000000000000", |
Contributor
There was a problem hiding this comment.
Does the test not work if we use alphanumeric strings?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Outline of Solution