docs(governance): propose communication-protocol rule (Ask/Question/Propose/Alert)#795
docs(governance): propose communication-protocol rule (Ask/Question/Propose/Alert)#795jordyamoedo wants to merge 2 commits into
Conversation
jordyamoedo
requested review from
Pedrovaleriolopez and
oalanicolas
as code owners
|
@jordyamoedo is attempting to deploy a commit to the SINKRA - AIOX Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughTwo new YAML files are added: an audit finding ( ChangesCommunication Protocol Audit-to-Proposal Pipeline
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Welcome to aiox-core! Thanks for your first pull request. What happens next?
PR Checklist:
Thanks for contributing! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@audits/promoted/AF-20260614-communication-protocol.yaml`:
- Around line 31-32: The references section uses an invalid kind value "pattern"
which is not in the allowed list specified by the audit-finding template. Update
the kind field in the references section from "pattern" to
"existing-pattern-source" to comply with the template specification that only
allows: ADR, code, hook, governance-doc, existing-pattern-source,
voice-clone-finding, voice-clone-personas, handoff-contract, audit, or proposal.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e7e84277-8c0e-44bb-8566-56d7ef76d85e
📒 Files selected for processing (2)
audits/promoted/AF-20260614-communication-protocol.yamlgovernance/proposals/PROP-20260614-communication-protocol.yaml
| - kind: pattern | ||
| path: "Agents are specialists, not blind executors — four modes" |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
What are the current allowed reference kinds in the aiox-core audit-finding schema?
💡 Result:
Based on the available documentation and codebase for aiox-core as of June 2026, there is no explicit entity titled "audit-finding schema" that defines a standardized list of "reference kinds." The aiox-core framework utilizes a multi-layered quality gate system [1][2] and specific workflow task definitions [3][4] to manage audits. Audit results and findings are typically structured as markdown reports (e.g., SCHEMA.md, DB-AUDIT.md) or processed via quality gate JSON schemas [3][1][5]. In these workflows, "references" are generally handled through: 1. Task and Action References: Workflows refer to external task definitions (e.g., db-schema-audit.md) and checklists (e.g., database-design-checklist.md) [5]. 2. Output Destinations: Findings are categorized by their output destination, which includes Memory, File, API, or Database [3]. 3. Quality Metrics: Automated audit metrics are governed by the quality-metrics.schema.json, which defines structure for layers, trends, and history, rather than specific "reference kinds" for findings [1]. If you are encountering a specific error message or schema validation requirement regarding "reference kinds," it may be related to custom implementation logic within your specific squad or project-level configuration, rather than a global schema definition in the core framework.
Citations:
- 1: https://synkraai-aiox-core-74.mintlify.app/workflows/quality-gates
- 2: https://github.com/SynkraAI/aiox-core/blob/main/docs/guides/quality-gates.md
- 3: https://synkraai-aiox-core-74.mintlify.app/api/tasks
- 4: https://synkraai-aiox-core-74.mintlify.app/concepts/workflows
- 5: 0431d04
🏁 Script executed:
#!/bin/bash
# Find the audit file mentioned in the review
find . -name "AF-20260614-communication-protocol.yaml" -o -name "*audit-finding-tmpl*" 2>/dev/null | head -20Repository: SynkraAI/aiox-core
Length of output: 167
🏁 Script executed:
#!/bin/bash
# Search for governance templates directory
find . -type d -name "governance" 2>/dev/null | head -10Repository: SynkraAI/aiox-core
Length of output: 94
🏁 Script executed:
#!/bin/bash
# Search for any files with "template" or "tmpl" in audit/promoted directory
find . -path "*/audits/promoted*" -type f 2>/dev/null | head -20Repository: SynkraAI/aiox-core
Length of output: 242
🏁 Script executed:
#!/bin/bash
cat -n ./audits/promoted/AF-20260614-communication-protocol.yamlRepository: SynkraAI/aiox-core
Length of output: 2309
🏁 Script executed:
#!/bin/bash
cat -n ./governance/templates/audit-finding-tmpl.yamlRepository: SynkraAI/aiox-core
Length of output: 2532
Change reference kind from "pattern" to "existing-pattern-source".
The references section at lines 31–32 uses kind: pattern, but the audit-finding template specifies allowed kinds as: ADR | code | hook | governance-doc | existing-pattern-source | voice-clone-finding | voice-clone-personas | handoff-contract | audit | proposal (governance/templates/audit-finding-tmpl.yaml, lines 38–39).
Based on the reference content, existing-pattern-source is the appropriate kind. Update line 31 accordingly.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@audits/promoted/AF-20260614-communication-protocol.yaml` around lines 31 -
32, The references section uses an invalid kind value "pattern" which is not in
the allowed list specified by the audit-finding template. Update the kind field
in the references section from "pattern" to "existing-pattern-source" to comply
with the template specification that only allows: ADR, code, hook,
governance-doc, existing-pattern-source, voice-clone-finding,
voice-clone-personas, handoff-contract, audit, or proposal.
1 participant
Summary
This proposes a communication-protocol rule for agents — submitted through the project's own
governance/evolution-pipeline.mdas anAuditFinding+FrameworkProposal(bothPENDINGyour approval). Two governance YAML files; no code paths touched.The gap
There's no shared protocol for how agents communicate when they hit a wall — insufficient context, a flawed requirement, a better alternative, or a risk. Without it, agents tend to execute blindly or stay silent to look efficient.
The proposal
Agents are specialists, not blind executors. Four modes:
Plus the anti-patterns to avoid: never assume unprovided context, never invent requirements, never execute silently under critical ambiguity, never deliver incomplete output without flagging it.
Why it's good for the project
Submitted in the spirit of the framework's own evolution pipeline. Happy to follow up with refinements per your guidance.
Summary by CodeRabbit
New Features
Documentation