Update Match methods for nullable references#227
Open
calielc wants to merge 4 commits intoSwissLife-OSS:masterfrom
Open
Update Match methods for nullable references#227calielc wants to merge 4 commits intoSwissLife-OSS:masterfrom
calielc wants to merge 4 commits intoSwissLife-OSS:masterfrom
Conversation
…tchOptions, MatchOptions>` parameters.
… where applicable.
…nable Fix typo and update test methods for nullable references
Author
|
Tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating
Func<MatchOptions, MatchOptions> matchOptions = nulltoFunc<MatchOptions, MatchOptions>? matchOptions = nullthis was causing warnings into your code base and not building on a downstream reference when sendingnull.Given the fact
matchOptionscan be null when no value is passed and down into the call ofAssertSnapshotalso supportsnullvalue, IMHO is pretty safe to mark the interface as?