#1101: Scan QR code from saved picture#1143
Open
liammaloney2403 wants to merge 2 commits intoSwati4star:masterfrom
Open
#1101: Scan QR code from saved picture#1143liammaloney2403 wants to merge 2 commits intoSwati4star:masterfrom
liammaloney2403 wants to merge 2 commits intoSwati4star:masterfrom
Conversation
|
Code Climate has analyzed commit bdf11ab and detected 4 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Swati4star
reviewed
Nov 17, 2023
| <menu xmlns:android="http://schemas.android.com/apk/res/android"> | ||
| <item | ||
| android:id="@+id/camera" | ||
| android:title="Take a photo of code" /> |
Owner
There was a problem hiding this comment.
Can you use strings.xml string instead?
This was referenced Nov 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. List any dependencies that are
required for this change.
If there are any UI change, please include the screenshots also.
Fixes #1101
Type of change
Just put an x in the [] which are valid.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
./gradlew assembleDebug assembleRelease./gradlew checkstyleChecklist:
UI screenshots:
